Conversation
Summary of ChangesHello @JaeoneLim, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 블로그 게시물의 전반적인 로딩 성능을 향상시키기 위해 이미지 및 GIF 파일을 최적화하는 데 중점을 둡니다. 특히, 용량이 큰 GIF 파일들을 MP4 비디오 또는 JPG 이미지로 대체하여 페이지 로딩 시간을 단축하고 사용자 경험을 개선하는 것을 목표로 합니다. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
54dc95e to
cc89ea7
Compare
There was a problem hiding this comment.
Pull request overview
This PR reduces media size across several blog posts by compressing images/GIFs and replacing at least one GIF with a static image (LPU deep dive) and another with an MP4 embed (TPU deep dive).
Changes:
- Replaced the “Speculative Decoding” GIF reference in LPU deep dive posts with a JPG.
- Replaced the “Systolic array visualization” GIF in TPU deep dive posts with an embedded MP4 video.
- Updated/compressed multiple image assets across LPU deep dive and how-GPU-works posts.
Reviewed changes
Copilot reviewed 4 out of 47 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| content/posts/lpu-deep-dive/index.ko.md | Switch speculative decoding media from GIF to JPG reference. |
| content/posts/lpu-deep-dive/index.en.md | Switch speculative decoding media from GIF to JPG reference. |
| content/posts/lpu-deep-dive/images/roofline_concept.jpg | Compressed/updated image asset. |
| content/posts/lpu-deep-dive/images/remove_ctrl_logic.png | Compressed/updated image asset. |
| content/posts/lpu-deep-dive/images/gpu_memory_hierarchy.png | Compressed/updated image asset. |
| content/posts/lpu-deep-dive/images/all_reduce.png | Compressed/updated image asset. |
| content/posts/lpu-deep-dive/gifs/speculative-decoding.gif | Removed/replaced (no longer referenced from the post). |
| content/posts/how-GPU-works/images/gpu-cuda-logo.png | Compressed/updated image asset. |
| content/posts/how-GPU-works/images/14-thdblk-alloc.png | Compressed/updated image asset. |
| content/posts/how-GPU-works/images/13-cuda-pm.png | Compressed/updated image asset. |
| content/posts/TPU-deep-dive/index.ko.md | Replace GIF embed with MP4 <video> embed via shortcode. |
| content/posts/TPU-deep-dive/index.en.md | Replace GIF embed with MP4 <video> embed via shortcode. |
| content/posts/TPU-deep-dive/systolic_array.gif | Removed/replaced (now using MP4 embed). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {{< rawhtml >}} | ||
| <video autoplay loop muted playsinline width="100%" style="max-width: 100%; border-radius: 8px;"> | ||
| <source src="/posts/TPU-deep-dive/systolic_array.mp4" type="video/mp4"> | ||
| 브라우저가 비디오 재생을 지원하지 않습니다. | ||
| </video> | ||
| {{< /rawhtml >}} |
There was a problem hiding this comment.
{{< rawhtml >}} shortcode is used here, but the repository doesn’t contain a layouts/shortcodes/rawhtml.html (and Goldmark unsafe HTML isn’t enabled in hugo.yaml). As-is, Hugo will fail to render the page or strip the <video> tag. Add the rawhtml shortcode (or enable markup.goldmark.renderer.unsafe: true and embed the <video> directly).
| {{< rawhtml >}} | |
| <video autoplay loop muted playsinline width="100%" style="max-width: 100%; border-radius: 8px;"> | |
| <source src="/posts/TPU-deep-dive/systolic_array.mp4" type="video/mp4"> | |
| 브라우저가 비디오 재생을 지원하지 않습니다. | |
| </video> | |
| {{< /rawhtml >}} | |
| <video autoplay loop muted playsinline width="100%" style="max-width: 100%; border-radius: 8px;"> | |
| <source src="/posts/TPU-deep-dive/systolic_array.mp4" type="video/mp4"> | |
| 브라우저가 비디오 재생을 지원하지 않습니다. | |
| </video> |
|  | ||
| {{< rawhtml >}} | ||
| <video autoplay loop muted playsinline width="100%" style="max-width: 100%; border-radius: 8px;"> | ||
| <source src="/posts/TPU-deep-dive/systolic_array.mp4" type="video/mp4"> |
There was a problem hiding this comment.
The <source> uses an absolute path (/posts/TPU-deep-dive/systolic_array.mp4). This is brittle if the site is ever hosted under a subpath or if Hugo’s output path casing differs; it also diverges from the relative asset links used elsewhere in the post bundle. Prefer a relative URL to the page bundle resource (e.g., systolic_array.mp4) or generate the URL via Hugo helpers/shortcode so it’s always correct.
| <source src="/posts/TPU-deep-dive/systolic_array.mp4" type="video/mp4"> | |
| <source src="systolic_array.mp4" type="video/mp4"> |
| {{< rawhtml >}} | ||
| <video autoplay loop muted playsinline width="100%" style="max-width: 100%; border-radius: 8px;"> | ||
| <source src="/posts/TPU-deep-dive/systolic_array.mp4" type="video/mp4"> | ||
| Your browser does not support the video tag. | ||
| </video> | ||
| {{< /rawhtml >}} |
There was a problem hiding this comment.
{{< rawhtml >}} shortcode is used here, but the repository doesn’t contain a layouts/shortcodes/rawhtml.html (and Goldmark unsafe HTML isn’t enabled in hugo.yaml). As-is, Hugo will fail to render the page or strip the <video> tag. Add the rawhtml shortcode (or enable markup.goldmark.renderer.unsafe: true and embed the <video> directly).
| {{< rawhtml >}} | |
| <video autoplay loop muted playsinline width="100%" style="max-width: 100%; border-radius: 8px;"> | |
| <source src="/posts/TPU-deep-dive/systolic_array.mp4" type="video/mp4"> | |
| Your browser does not support the video tag. | |
| </video> | |
| {{< /rawhtml >}} | |
| [Watch the systolic array animation (MP4)](/posts/TPU-deep-dive/systolic_array.mp4) |
|
review |
지피지기 1~3편 블로그 포스트의 이미지 및 gif 압축 진행하였습니다.
1MB 이하로 압축이 안되는 gif가 있어 이는 mp4로 대체하였습니다.